Skip to content

[v6] deprecate import.meta.env.ASSETS_PREFIX#12468

Merged
florian-lefebvre merged 3 commits into
v6from
feat/deprecate-import-meta-env-assets-prefix
Oct 1, 2025
Merged

[v6] deprecate import.meta.env.ASSETS_PREFIX#12468
florian-lefebvre merged 3 commits into
v6from
feat/deprecate-import-meta-env-assets-prefix

Conversation

@florian-lefebvre

@florian-lefebvre florian-lefebvre commented Sep 30, 2025

Copy link
Copy Markdown
Member

Co-authored-by: Sarah Rainsberger [email protected]

Description (required)

Related issues & labels (optional)

  • Closes #
  • Suggested label:

For Astro version: 6.0. See astro PR #14461.

@florian-lefebvre florian-lefebvre added this to the v6.0.0 docs milestone Sep 30, 2025
@netlify

netlify Bot commented Sep 30, 2025 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 18f4e99
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/68dd3f7fe03ec90008d928f9
😎 Deploy Preview https://deploy-preview-12468--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

florian-lefebvre
florian-lefebvre commented Sep 30, 2025
View reviewed changes
Comment thread src/content/docs/en/guides/environment-variables.mdx Outdated
@astrobot-houston

astrobot-houston commented Sep 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/environment-variables.mdx Source changed, localizations will be marked as outdated.
en/guides/upgrade-to/v6.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@florian-lefebvre florian-lefebvre mentioned this pull request Sep 30, 2025
Merged
ArmandPhilippot
ArmandPhilippot reviewed Oct 1, 2025
View reviewed changes
Comment thread src/content/docs/en/guides/upgrade-to/v6.mdx Outdated
sarah11918
sarah11918 reviewed Oct 1, 2025
View reviewed changes

@sarah11918 sarah11918 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Florian! Left some suggestions here for you to consider, and yes, all those "5.x" are in fact correct!

Comment thread src/content/docs/en/guides/environment-variables.mdx Outdated
Comment thread src/content/docs/en/guides/upgrade-to/v6.mdx Outdated
Comment thread src/content/docs/en/guides/upgrade-to/v6.mdx Outdated
Comment thread src/content/docs/en/guides/upgrade-to/v6.mdx Outdated
Comment thread src/content/docs/en/guides/upgrade-to/v6.mdx Outdated
Comment thread src/content/docs/en/guides/upgrade-to/v6.mdx Outdated
florian-lefebvre and others added 2 commits October 1, 2025 16:48
@florian-lefebvre @sarah11918
Apply suggestions from code review
a4c9552 
Co-authored-by: Sarah Rainsberger <[email protected]>
@florian-lefebvre @sarah11918
Apply suggestions from code review
18f4e99 
Co-authored-by: Sarah Rainsberger <[email protected]>
sarah11918
sarah11918 approved these changes Oct 1, 2025
View reviewed changes

@sarah11918 sarah11918 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@florian-lefebvre
florian-lefebvre merged commit 43e9116 into v6 Oct 1, 2025
10 checks passed
@florian-lefebvre
florian-lefebvre deleted the feat/deprecate-import-meta-env-assets-prefix branch October 1, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArmandPhilippot ArmandPhilippot ArmandPhilippot left review comments
@sarah11918 sarah11918 sarah11918 approved these changes

Assignees

No one assigned

Labels

6.0

Projects

None yet

Milestone

v6.0.0 docs

Development

Successfully merging this pull request may close these issues.

4 participants

@florian-lefebvre @astrobot-houston @sarah11918 @ArmandPhilippot