feat: emit template depth tracking instructions#1156
Conversation
🦋 Changeset detectedLatest commit: b068089 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
0b513fd to
75ca0b5
Compare
|
@matthewp @Princesseuh Hello! Sorry for ping, but would you mind reviewing this? |
75ca0b5 to
d05ca15
Compare
d05ca15 to
a0a1082
Compare
|
@matthewp @Princesseuh Sorry for pinging again =) So, after Rust PR is approved, what are next the next steps? We also have this one implementation, and the PR in Astro itself .. |
|
@matthewp @Princesseuh weekly ping =) |
|
Hello, yes, sorry! We'll get to it. Just needs to be careful here because Astro uses the compiler as |
Co-authored-by: Erika <[email protected]>
Princesseuh
left a comment
Princesseuh
left a comment
There was a problem hiding this comment.
Awesome work, apologies for the delay!
2 participants
This PR adds a special handling for
<template>tags, so they call specialtemplateEnterandtemplateExitfunctions. It's necessary for withastro/astro#15980 PR.Changes
print-to-js.gonow detectstemplatenodes and addstemplateEnter/templateExitcalls inside.transform/transform.gonow fillsContainsTemplateElementflag to be able to dynamically include imports later.Testing
<template>case and nested caseDocs
I'm unsure whether it should be documented. I can add the documentation somewhere if needed.