Unflag advanced routing#16877
Open
matthewp wants to merge 6 commits into
Open
Conversation
## Goal Remove the experimental.advancedRouting flag and enable the feature by default. Move fetchFile to a top-level config option. RFC: withastro/roadmap#1344 ## Decisions - fetchFile becomes a top-level config option (string | null, default 'app') instead of being nested under experimental.advancedRouting. The boolean gate is gone — the vite plugin always resolves src/app.ts if it exists. - Users who had experimental.advancedRouting: true can simply delete it. - Users who had experimental.advancedRouting: { fetchFile: 'fetch.ts' } move to the top-level: fetchFile: 'fetch.ts'. ## Changes - base.ts: Moved default and zod schema from experimental to top-level. - config.ts: Moved type from experimental to top-level with JSDoc. - vite-plugin.ts: Reads settings.config.fetchFile directly, removed advancedRoutingEnabled gate. - Example config: Removed experimental block. - reference/handlers.md: Removed experimental mention.
🦋 Changeset detectedLatest commit: c2b2ca6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 398 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The fixture has a src/app.ts that is a Vue app entrypoint, not an Astro fetch handler. With advanced routing always enabled, it was being loaded as the fetch handler, breaking the SSR test.
Contributor
Author
|
Forgot to push the changeset, it's in 680835e |
Co-authored-by: Armand Philippot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
experimental.advancedRoutingflag and enables the feature by default.fetchFileis now a top-level config option (string | null, default'fetch') instead of being nested underexperimental.advancedRouting.src/fetch.tsif present — no flag needed.fetchFile: nulldisables the entrypoint.RFC: withastro/roadmap#1344
Testing
Docs