Skip to content

docs: fix typos in astro:i18n middleware JSDoc#16574

Merged
ematipico merged 1 commit into
withastro:mainfrom
dfedoryshchev:docs/fix-typos-in-i18n-virtual-module-jsdoc
May 29, 2026
Merged

docs: fix typos in astro:i18n middleware JSDoc#16574
ematipico merged 1 commit into
withastro:mainfrom
dfedoryshchev:docs/fix-typos-in-i18n-virtual-module-jsdoc

Conversation

@dfedoryshchev

Copy link
Copy Markdown
Contributor

Fixes three small grammar typos in the JSDoc above astro:i18n's exported middleware (packages/astro/src/virtual-modules/i18n.ts):

  • "allows to programmatically create" -> "allows you to programmatically create"
  • "is use useful" -> "is useful"
  • "only few exceptions" -> "only a few exceptions"

The "allows you to" phrasing matches the convention used throughout the rest of the repo (CHANGELOGs use it 20+ times). Comment-only change, no behavior impact.

@changeset-bot

changeset-bot Bot commented May 2, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ded6cb3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added the pkg: astro Related to the core `astro` package (scope) label May 2, 2026
@codspeed-hq

codspeed-hq Bot commented May 2, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 18 untouched benchmarks


Comparing dfedoryshchev:docs/fix-typos-in-i18n-virtual-module-jsdoc (ded6cb3) with main (17f1867)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (7711e47) during the generation of this report, so 17f1867 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@dfedoryshchev

Copy link
Copy Markdown
Contributor Author

Hey guys!

A gentle reminder about this PR.

@ematipico ematipico merged commit 86e1190 into withastro:main May 29, 2026
27 checks passed
ematipico added a commit that referenced this pull request Jun 2, 2026
* chore(deps): resolve peer dependency issues (#16894)

* chore(deps): update eslint to v10 (#16896)

* test(vercel): add per-test timeout and raise suite timeout (#16898)

* chore: eliminate duplicate pnpm configurations (#16906)

* Fix i18n redirectToDefaultLocale not working with prefixDefaultLocale (#16887)

* fix(i18n): preserve ROUTE_TYPE_HEADER for i18n post-processing (#16800)

* chore: move fix somewhere else

* chore: update changeset

---------

Co-authored-by: ematipico <[email protected]>

* feat(fonts): better bold fallbacks (#16908)

* [ci] format

* fix(docs): replace last occurrences of `withastro/adapters` (#16693)

* fix: astro() marks all pipeline features as used (#16899)

* fix: astro() marks all pipeline features as used

AstroHandler is the batteries-included handler that wires up every
pipeline feature internally. Mark all PipelineFeatures bits at the
top of handle() so the one-shot warnMissingFeatures check in BaseApp
never fires a false positive when the first request short-circuits
(e.g. a redirect route skips middleware).

* add changeset

* move allFeatures mask to base-pipeline.ts per review

* docs: fix typos in astro:i18n middleware JSDoc (#16574)

* docs: fix outdated Partytown link (#16865)

* chore(deps): update devalue (#16900)

* Pre-bundle astro/fetch and astro/hono in Cloudflare optimizeDeps (#16914)

## Goal
Eliminate the 'new dependencies optimized: astro/fetch' warning during dev
in the Cloudflare adapter. The advanced routing feature (d69f858, #16366)
introduced astro/fetch and astro/hono exports, and the Cloudflare handler
entry points (01aa164, #16729) import from them — but neither commit
added these to the optimizeDeps.include list. Vite discovers them at runtime
and triggers a late re-optimization.

## Decisions
- Added both astro/fetch and astro/hono: the Cloudflare adapter imports from
  both (hono.ts imports FetchState from astro/fetch, and astro/hono is used
  similarly). Pre-bundling both prevents the same issue for either entry point.

## Changes
- packages/integrations/cloudflare/src/index.ts: added astro/fetch and
  astro/hono to the server environment optimizeDeps.include array, alongside
  the existing astro/app and astro/app/fetch/default-handler entries.

* fix(node): serve prerendered pages with build.format 'file' and 'preserve' by passing extensions option to send (#16922)

* [ci] format

* chore(deps): update `pnpm/action-setup` to v6 (#16904)

* chore(deps): update pnpm to v11.5.0 (#16903)

* Fix 404 route resolution for experimental.advancedRouting with astro/hono handlers (#16911)

Co-authored-by: Emanuele Stoppa <[email protected]>
Co-authored-by: Matthew Phillips <[email protected]>

* dedupe

---------

Co-authored-by: ocavue <[email protected]>
Co-authored-by: btea <[email protected]>
Co-authored-by: Houston (Bot) <[email protected]>
Co-authored-by: Florian Lefebvre <[email protected]>
Co-authored-by: Florian Lefebvre <[email protected]>
Co-authored-by: Armand Philippot <[email protected]>
Co-authored-by: Matthew Phillips <[email protected]>
Co-authored-by: dfedoryshchev <[email protected]>
Co-authored-by: Andreas Deininger <[email protected]>
Co-authored-by: Houston (Bot) <[email protected]>
Co-authored-by: Matthew Phillips <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants