Fix false positive missing-content audit for hidden anchors#16016
Conversation
🦋 Changeset detectedLatest commit: 1ce69a8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| 'Headings and anchors must have an accessible name, which can come from: text content, aria-label, aria-labelledby, an img with alt property, or an svg with a tag <title></title>.', | ||
| selector: a11y_required_content.join(','), | ||
| match(element: HTMLElement) { | ||
| // innerText is used to ignore hidden text |
There was a problem hiding this comment.
we used innerText on purpose, as this removed comment explains.
matthewp
left a comment
There was a problem hiding this comment.
we intentionally use innerText
16868f4 to
1ce69a8
Compare
|
Updated this to keep the existing |
* chore: move integration tests to unit tests (#16869) * chore(deps): replace which-pm-runs with package-manager-detector (#16901) * chore(deps): update dependency hono to v4.12.18 [security] (#16669) * Fix false positive missing-content audit for hidden anchors (#16016) * fix: remove dead else branch in csp insertDirective (#16921) Co-authored-by: Emanuele Stoppa <[email protected]> * chore: avoid formatter conflicts (#16897) --------- Co-authored-by: ocavue <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Felmon <[email protected]> Co-authored-by: Stefan Machhammer <[email protected]>
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [astro](https://astro.build) ([source](https://github.com/withastro/astro/tree/HEAD/packages/astro)) | [`6.4.2` → `6.4.3`](https://renovatebot.com/diffs/npm/astro/6.4.2/6.4.3) |  |  | --- ### Release Notes <details> <summary>withastro/astro (astro)</summary> ### [`v6.4.3`](https://github.com/withastro/astro/blob/HEAD/packages/astro/CHANGELOG.md#643) [Compare Source](https://github.com/withastro/astro/compare/[email protected]@6.4.3) ##### Patch Changes - [#​16900](withastro/astro#16900) [`17a0fbd`](withastro/astro@17a0fbd) Thanks [@​ocavue](https://github.com/ocavue)! - Bumps `devalue` dependency to v5.8.1 - [#​16016](withastro/astro#16016) [`0d85e1b`](withastro/astro@0d85e1b) Thanks [@​felmonon](https://github.com/felmonon)! - Fix a false positive in the dev toolbar accessibility audit for anchors with text inside closed `<details>` elements. - [#​16911](withastro/astro#16911) [`79c6c46`](withastro/astro@79c6c46) Thanks [@​astrobot-houston](https://github.com/astrobot-houston)! - Fixes a bug where `experimental.advancedRouting` with `astro/hono` handlers threw `TypeError: Cannot read properties of undefined (reading 'route')` for unmatched routes instead of rendering the custom 404 page. - [#​16899](withastro/astro#16899) [`239c469`](withastro/astro@239c469) Thanks [@​matthewp](https://github.com/matthewp)! - Fixes a false "does not call the middleware() handler" warning when using `astro()` in a custom `src/app.ts` and the first request is a redirect route. - [#​16887](withastro/astro#16887) [`493acdb`](withastro/astro@493acdb) Thanks [@​astrobot-houston](https://github.com/astrobot-houston)! - Fixes `redirectToDefaultLocale` not working after the Advanced Routing refactoring. - [#​16908](withastro/astro#16908) [`ef53ab9`](withastro/astro@ef53ab9) Thanks [@​florian-lefebvre](https://github.com/florian-lefebvre)! - Improves optimized fallbacks generation when using the Fonts API by using better metrics for bold variants </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yMDUuMyIsInVwZGF0ZWRJblZlciI6IjQzLjIwNS4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Summary
Details
so hidden-but-valid text is not flaggedTesting
Fixes #16009