Skip to content

Add Node 22 engines field to examples#15330

Merged
ematipico merged 2 commits into
nextfrom
update-examples-engines
Jan 30, 2026
Merged

Add Node 22 engines field to examples#15330
ematipico merged 2 commits into
nextfrom
update-examples-engines

Conversation

@matthewp

@matthewp matthewp commented Jan 28, 2026

Copy link
Copy Markdown
Contributor

Changes

Testing

No tests needed - this only adds metadata to package.json files.

Docs

No docs needed - this is an internal change to examples that does not affect user behavior.

Stackblitz now supports Node 22 and this is how you opt-in.
@changeset-bot

changeset-bot Bot commented Jan 28, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 45613d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added the pkg: example Related to an example package (scope) label Jan 28, 2026
@github-actions

github-actions Bot commented Jan 28, 2026

Copy link
Copy Markdown
Contributor

⚠️ Package Trust Level Decreased

Caution

Decreased trust levels may indicate a higher risk of supply chain attacks. Please review these changes carefully.

📦 Package 🔒 Before 🔓 After
eslint-plugin-regexp trusted-with-provenance none
@cloudflare/kv-asset-handler trusted-with-provenance none
@cloudflare/unenv-preset trusted-with-provenance none
workerd trusted-with-provenance none
@sveltejs/vite-plugin-svelte-inspector trusted-with-provenance provenance
@sveltejs/vite-plugin-svelte trusted-with-provenance provenance
jsdoc-type-pratt-parser trusted-with-provenance none
miniflare trusted-with-provenance none
youch provenance none
@cloudflare/workerd-darwin-64 trusted-with-provenance none
@cloudflare/workerd-darwin-arm64 trusted-with-provenance none
@cloudflare/workerd-linux-64 trusted-with-provenance none
@cloudflare/workerd-linux-arm64 trusted-with-provenance none
@cloudflare/workerd-windows-64 trusted-with-provenance none
wrangler trusted-with-provenance none

@HiDeoo HiDeoo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this match the new lowest required Node.js version (22.12.0) to potentially avoid confusion with the upgrade guide and docs saying we support at least 22.12.0 but the engines field using another minimum version?

@matthewp

Copy link
Copy Markdown
Contributor Author

@HiDeoo 22.22.0 is the version Stackblitz supports, so I think we should bump to that.

@HiDeoo

HiDeoo commented Jan 28, 2026

Copy link
Copy Markdown
Member

@HiDeoo 22.22.0 is the version Stackblitz supports, so I think we should bump to that.

Yeah, but using >=22.12.0 will also pick the minimum version they support:

image

Both works but I thought using our minimum version could potentially avoid some user confusions.

@matthewp matthewp self-assigned this Jan 29, 2026
@matthewp

Copy link
Copy Markdown
Contributor Author

@HiDeoo switched to >=22.12.0

@HiDeoo HiDeoo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for considering the change 🙌

Looks perfect to me, and hopefully we can remove them at some point in the future.

@ematipico
ematipico merged commit bb84e0f into next Jan 30, 2026
23 checks passed
@ematipico
ematipico deleted the update-examples-engines branch January 30, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: example Related to an example package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants