Skip to content

fix(fonts): font providers as class instances#15286

Merged
florian-lefebvre merged 1 commit intomainfrom
fix/fonts-provider-instance
Jan 23, 2026
Merged

fix(fonts): font providers as class instances#15286
florian-lefebvre merged 1 commit intomainfrom
fix/fonts-provider-instance

Conversation

@florian-lefebvre
Copy link
Member

Changes

  • Reported by a user on Discord: TypeError: Cannot write private member #root to an object whose class did not declare it
  • Zod remaps object but we want to keep the initial value instead, so that this remains valid

Testing

Manually + unit test

Docs

Changeset

@florian-lefebvre florian-lefebvre self-assigned this Jan 23, 2026
@changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2026

🦋 Changeset detected

Latest commit: 187d94f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 23, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 23, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing fix/fonts-provider-instance (187d94f) with main (7db2fda)1

Summary

✅ 9 untouched benchmarks

Footnotes

  1. No successful run was found on main (f7a8415) during the generation of this report, so 7db2fda was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@florian-lefebvre florian-lefebvre merged commit 0aafc83 into main Jan 23, 2026
26 checks passed
@florian-lefebvre florian-lefebvre deleted the fix/fonts-provider-instance branch January 23, 2026 08:59
@astrobot-houston astrobot-houston mentioned this pull request Jan 23, 2026
dadezzz pushed a commit to dadezzz/ice-notes that referenced this pull request Jan 27, 2026
This PR contains the following updates:

| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [astro](https://astro.build) ([source](https://github.com/withastro/astro/tree/HEAD/packages/astro)) | [`5.16.14` → `5.16.15`](https://renovatebot.com/diffs/npm/astro/5.16.14/5.16.15) | ![age](https://developer.mend.io/api/mc/badges/age/npm/astro/5.16.15?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/astro/5.16.14/5.16.15?slim=true) |

---

### Release Notes

<details>
<summary>withastro/astro (astro)</summary>

### [`v5.16.15`](https://github.com/withastro/astro/blob/HEAD/packages/astro/CHANGELOG.md#51615)

[Compare Source](https://github.com/withastro/astro/compare/[email protected]@5.16.15)

##### Patch Changes

- [#&#8203;15286](withastro/astro#15286) [`0aafc83`](withastro/astro@0aafc83) Thanks [@&#8203;florian-lefebvre](https://github.com/florian-lefebvre)! - Fixes a case where font providers provided as class instances may not work when using the experimental Fonts API. It affected the local provider

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi45Mi40IiwidXBkYXRlZEluVmVyIjoiNDIuOTIuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: Renovate Bot <[email protected]>
Co-committed-by: Renovate Bot <[email protected]>
florian-lefebvre added a commit that referenced this pull request Jan 30, 2026
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Emanuele Stoppa <[email protected]>
Co-authored-by: Matt Kane <[email protected]>
Co-authored-by:  Matthew Phillips <[email protected]>
Co-authored-by: Matthew Phillips <[email protected]>
Co-authored-by: Florian Lefebvre <[email protected]>
Co-authored-by: Erika <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Armand Philippot <[email protected]>
Co-authored-by: matthewp <[email protected]>
Co-authored-by: florian-lefebvre <[email protected]>
Co-authored-by: ematipico <[email protected]>
Co-authored-by: Luiz Ferraz <[email protected]>
Co-authored-by: HiDeoo <[email protected]>
Co-authored-by: Princesseuh <[email protected]>
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Claude Opus 4.5 <[email protected]>
Co-authored-by: Antony Faris <[email protected]>
Co-authored-by: Erika <[email protected]>
Co-authored-by: Houston (Bot) <[email protected]>
Co-authored-by: Florian Lefebvre <[email protected]>
Co-authored-by: Volpeon <[email protected]>
Co-authored-by: Martin Trapp <[email protected]>
Co-authored-by: fkatsuhiro <[email protected]>
Co-authored-by: Oliver Speir <[email protected]>
Co-authored-by: Andreas Deininger <[email protected]>
Co-authored-by: Roman <[email protected]>
Co-authored-by: fabon <[email protected]>
Co-authored-by: Raanelom <[email protected]>
Co-authored-by: Rahul Dogra <[email protected]>
Co-authored-by: James Garbutt <[email protected]>
Co-authored-by: Pegasus <[email protected]>
Co-authored-by: Cameron Smith <[email protected]>
Co-authored-by: Martin Trapp <[email protected]>
Co-authored-by: Rafael ヤスヒデ 須藤 <[email protected]>
Co-authored-by: Matthew Phillips <[email protected]>
Co-authored-by: Julien Cayzac <[email protected]>
Co-authored-by: Drew Powers <[email protected]>
Co-authored-by: Emanuele Stoppa <[email protected]>
Co-authored-by: MkDev11 <[email protected]>
Co-authored-by: andy <[email protected]>
Co-authored-by: Luky Setiawan <[email protected]>
Co-authored-by: btea <[email protected]>
Co-authored-by: cid <[email protected]>
Co-authored-by: Simen Sagholen Førrisdal <[email protected]>
Co-authored-by: Alex Launi <[email protected]>
Co-authored-by: Kedar Vartak <[email protected]>
Co-authored-by: yy <[email protected]>
Co-authored-by: Matheus Baroni <[email protected]>
Co-authored-by: Kevin Brown <[email protected]>
Co-authored-by: Eric Grill <[email protected]>
Co-authored-by: Cameron Pak <[email protected]>
Co-authored-by: Tony Narlock <[email protected]>
Co-authored-by: John Mortlock <[email protected]>
Co-authored-by: Patrick Arlt <[email protected]>
Co-authored-by: Mark Ignacio <[email protected]>
fix(ci): Reinstall deps after having published VS Code (#14996)
fix(svelte): allow client directives (#15004)
fix(assets): Fixes missing format option for svgs in the passthrough service (#14987)
fix(deps): update all non-major dependencies (#15020)
fix(content-layer): Try a smarter solution to normalize bare image paths in JSON (#15028)
fix(astro): assets vite build log (#15034)
resolved (#15033)
fix: Remote images: Prevent internal caching from interfering with Astro's cache (#14954)
fix(deps): update astro adapters (#15084)
fix(deps): update all non-major dependencies (#15072)
fix(deps): update astro client runtimes (#15085)
fix: move ts-plugin node_modules to dist (#15083)
fix: components imports paths (#15107)
fix(assets): Use Vite's isFileLoadingAllowed to check if a file can be loaded (#15052)
fix(vscode): Correctly handle TypeScript blocks ending with types (#15109)
fix(svelte): improve Svelte children prop type checking (#15070)
fix Firefox e2e tests for playwright 1.57 (#15113)
fix(deps): update astro dependencies (#15103)
fix: lint vt test (#15114)
fix(deps): update language tools (#15104)
resolver abstraction (#15111)
fix(vue): add HTML attributes to generated TypeScript types (#15016)
Fixes #14686
fix(vscode): Don't update @types/vscode automatically (#15131)
fix: adjust page warning to only show up in more relevant times (#15127)
fix(dev): preserve query params when base path is stripped (#15124)
fix(assets): hoist ?? inside JSON.stringify in virtual module codegen (#15140)
fix(toolbar): skip image audit for framework components (#15149)
Fixes #15048
fix: Accept setCookie from both context and headers (#15152)
fix(ci): Move ts-plugin-bundle to node_modules after recreating node_modules (#15156)
fix: scripts not rendering with unused Fragment slots (#13847) (#15147)
Fix hydration for framework components in MDX slots (#15150)
fix(deps): update astro adapters (#15173)
fix: fix image 500 error when moving dist directory in standalone Node (#15169)
fix: Allow node: prefix for Node builtins for Vercel middleware (#14863)
fix: Allow node: prefix for Node builtins for Vercel middleware (#14839)"
fix(node): hash URL stripping (#15196)
fix(core): add defensive validation for mod.page in App.render (#15148)
fix(css): rewrite absolute URLs with base path in dev mode (#14622)
Closes #14585
fix(docs): replace outdated Astro docs links (#15199)
fix(lint): Move ESLint comment (#15216)
fix: update devalue to the latest (#15222)
fix(css): prevent CSS double-bundling (#14991) (#15017)
Fixes #14991
fix: assets referenced via js chunks are not flagged as orphaned (#14607)
fix(build): Prevent duplicate CSS for hydrated client components" (#14612)"
Fixes #14252
fix(deps): update astro client runtimes (#15240)
fix(deps): update astro adapters (#15243)
fix(deps): update astro dependencies (#15241)
fix(deps): update dependency prettier to ^3.8.0 (#15244)
fix(deps): update all non-major dependencies (#15242)
Fix greedy regex in error message markdown rendering (#15230)
Fixes #15068
fixes: #15252
fix: prevent font copying when stopping dev server with q+enter (#15178)
fix: renovate config typo (#15256)
Fixes #15251
fix: typo in comment (#15232)
fix(deps): update dependency svelte to v5.46.4 [security] (#15220)
fix: add favicon.ico fallbacks to all examples (#15262)
fix(cli): add .vercel to .gitignore when using astro add vercel (#15185)
Closes #15058
fix(fonts): font providers as class instances (#15286)
Fix: Remove await from getActionResult JSDoc example (#15304)
fix(errors): Only style valid URLs in the error overlay (#15324)
fix(fonts): remove getFontBuffer() (#15334)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants