feat(fonts)!: update font provider API#14980
Closed
florian-lefebvre wants to merge 5 commits intomainfrom
Closed
Conversation
|
github-actions
bot
added
the
pkg: astro
| // We set the provider name so we can tell unifont what provider to use when | ||
| // resolving font faces | ||
| // TODO: mutating is confusing. There must be a better pattern than this | ||
| provider.name = unifontProvider._name; |
Member
Author
There was a problem hiding this comment.
Instead keep an internal record of providers
This was referenced Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Todo
Changes
pnpm changeset.Testing
Docs