fix: passthroughImageService generate webp#14776
Merged
Princesseuh merged 6 commits intowithastro:mainfrom Nov 17, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 39c2469 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
ktym4a
commented
Nov 16, 2025
Comment on lines
8
to
16
| validateOptions(options, imageConfig) { | ||
| if (isESMImportedImage(options.src)) { | ||
| return { | ||
| src: options.src, | ||
| format: options.src.format, | ||
| }; | ||
| } | ||
| return baseService.validateOptions?.(options, imageConfig) ?? options; | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
I'm not sure if we should just override format then pass to validateOptions something like this.
if (isESMImportedImage(options.src)) {
options.format = options.src.format;
}
return baseService.validateOptions?.(options, imageConfig) ?? options;
Member
There was a problem hiding this comment.
I don't 100% remember this code, but would this work?
Suggested change
| validateOptions(options, imageConfig) { | |
| if (isESMImportedImage(options.src)) { | |
| return { | |
| src: options.src, | |
| format: options.src.format, | |
| }; | |
| } | |
| return baseService.validateOptions?.(options, imageConfig) ?? options; | |
| }, | |
| validateOptions(options, imageConfig) { | |
| const newOptions = baseService.validateOptions?.(options, imageConfig) ?? options; | |
| delete newOptions.format; | |
| return newOptions; | |
| }, |
Contributor
Author
There was a problem hiding this comment.
@Princesseuh
thanks!
it works, so I changed to 39c2469
CodSpeed Performance ReportMerging #14776 will not alter performanceComparing Summary
Footnotes |
Member
|
Test failure looks unrelated, awesome work |
Princesseuh
approved these changes
Nov 17, 2025
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Close #14721
passthroughImageServicewas generating images inWebPformat.validateOptionswhenESMImportedImageTesting
Docs