Skip to content

feat(assets): Always allow cropping and never upscale#14629

Merged
Princesseuh merged 1 commit into
nextfrom
feat/cropping
Oct 31, 2025
Merged

feat(assets): Always allow cropping and never upscale#14629
Princesseuh merged 1 commit into
nextfrom
feat/cropping

Conversation

@Princesseuh

@Princesseuh Princesseuh commented Oct 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Changes

Testing

Updated tests that tested old behaviour to test new behavior, ha

Docs

withastro/docs#12639

@changeset-bot

changeset-bot Bot commented Oct 28, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 27479ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added the pkg: astro Related to the core `astro` package (scope) label Oct 28, 2025
@florian-lefebvre

florian-lefebvre commented Oct 28, 2025

Copy link
Copy Markdown
Member

Does this address #13995?

@florian-lefebvre florian-lefebvre added this to the v6.0.0 milestone Oct 28, 2025
@Princesseuh

Princesseuh commented Oct 28, 2025

Copy link
Copy Markdown
Member Author

Does this address #13995?

Yea

florian-lefebvre
florian-lefebvre approved these changes Oct 28, 2025
View reviewed changes

@florian-lefebvre florian-lefebvre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, this is missing a changeset which can only be done after the docs PR

This was linked to issues Oct 28, 2025
Do not upscale images in the default image service #14465
Closed
getImage() silently fails to resize/crop images #13995
Closed
@Princesseuh Princesseuh mentioned this pull request Oct 29, 2025
Merged
@Princesseuh

Princesseuh commented Oct 29, 2025

Copy link
Copy Markdown
Member Author

There's a docs PR now, think I did it correctly

@Princesseuh
Princesseuh merged commit dfb51d4 into next Oct 31, 2025
31 of 32 checks passed
@Princesseuh
Princesseuh deleted the feat/cropping branch October 31, 2025 01:18
@florian-lefebvre

florian-lefebvre commented Oct 31, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

@Princesseuh FYI we don't merge code PRs until the docs PR and the changeset are done now, you'll know next time :)

@coderabbitai coderabbitai Bot mentioned this pull request Feb 21, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ematipico ematipico ematipico approved these changes
@florian-lefebvre florian-lefebvre florian-lefebvre approved these changes

Assignees

@Princesseuh Princesseuh

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Milestone

v6.0.0

Development

Successfully merging this pull request may close these issues.

Do not upscale images in the default image service getImage() silently fails to resize/crop images

3 participants

@Princesseuh @florian-lefebvre @ematipico