Skip to content

Fix: add muted to html boolean attributes#14562

Merged
matthewp merged 4 commits into
withastro:mainfrom
erbierc:fix-add-muted-to-htmlBooleanAttributes
Oct 17, 2025
Merged

Fix: add muted to html boolean attributes#14562
matthewp merged 4 commits into
withastro:mainfrom
erbierc:fix-add-muted-to-htmlBooleanAttributes

Conversation

@erbierc

@erbierc erbierc commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

Changes

#14553
One boolean HTML attribute behaved differently from others ("muted"). This change fixes that by adding this attribute to the list of HTML boolean attributes in the astro/packages/astro/src/runtime/server/render/util.ts file.
Before:
obraz
After:
obraz

Testing

This change was tested by linking a local copy of Astro to a local copy of this project. The results are in the screenshots above.

Docs

Not sure, probably not.
/cc @withastro/maintainers-docs for feedback!

@changeset-bot

changeset-bot Bot commented Oct 17, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 51ae177

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the pkg: astro Related to the core `astro` package (scope) label Oct 17, 2025
@erbierc

erbierc commented Oct 17, 2025

Copy link
Copy Markdown
Contributor Author

Unrelated note: would appreciate the hacktoberfest-accepted label, but it is not necessary!

@codspeed-hq

codspeed-hq Bot commented Oct 17, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #14562 will not alter performance

Comparing erbierc:fix-add-muted-to-htmlBooleanAttributes (51ae177) with main (6cdade4)1

Summary

✅ 6 untouched

Footnotes

  1. No successful run was found on main (1a23346) during the generation of this report, so 6cdade4 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@matthewp matthewp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@matthewp matthewp added the hacktoberfest-accepted This PR is accepted to contribute towards hacktoberfest label Oct 17, 2025
@matthewp

Copy link
Copy Markdown
Contributor

Closes #14553

@matthewp matthewp merged commit 722bba0 into withastro:main Oct 17, 2025
23 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Oct 17, 2025
@erbierc erbierc deleted the fix-add-muted-to-htmlBooleanAttributes branch October 17, 2025 21:27
richardnbanks pushed a commit to richardnbanks/astro-loader-youtube that referenced this pull request Oct 19, 2025
This PR contains the following updates:

| Package | Change | Age | Confidence |
|---|---|---|---|
| [astro](https://astro.build) ([source](https://github.com/withastro/astro/tree/HEAD/packages/astro)) | [`5.14.5` -> `5.14.6`](https://renovatebot.com/diffs/npm/astro/5.14.5/5.14.6) | [![age](https://developer.mend.io/api/mc/badges/age/npm/astro/5.14.6?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/astro/5.14.5/5.14.6?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>withastro/astro (astro)</summary>

### [`v5.14.6`](https://github.com/withastro/astro/blob/HEAD/packages/astro/CHANGELOG.md#5146)

[Compare Source](https://github.com/withastro/astro/compare/[email protected]@5.14.6)

##### Patch Changes

- [#&#8203;14562](withastro/astro#14562) [`722bba0`](withastro/astro@722bba0) Thanks [@&#8203;erbierc](https://github.com/erbierc)! - Fixes a bug where the behavior of the "muted" HTML attribute was inconsistent with that of other attributes.

- [#&#8203;14538](withastro/astro#14538) [`51ebe6a`](withastro/astro@51ebe6a) Thanks [@&#8203;florian-lefebvre](https://github.com/florian-lefebvre)! - Improves how Actions are implemented

- [#&#8203;14548](withastro/astro#14548) [`6cdade4`](withastro/astro@6cdade4) Thanks [@&#8203;ascorbic](https://github.com/ascorbic)! - Removes support for the `maxAge` property in `cacheHint` objects returned by live loaders.

##### ⚠️ Breaking change for experimental live content collections only

Feedback showed that this did not make sense to set at the loader level, since the loader does not know how long each individual entry should be cached for.

If your live loader returns cache hints with `maxAge`, you need to remove this property:

```diff
return {
  entries: [...],
  cacheHint: {
    tags: ['my-tag'],
-   maxAge: 60,
    lastModified: new Date(),
  },
};
```

The `cacheHint` object now only supports `tags` and `lastModified` properties. If you want to set the max age for a page, you can set the headers manually:

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS45OS4xMSIsInVwZGF0ZWRJblZlciI6IjQxLjk5LjExIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Reviewed-on: https://code.richardbanks.dev/richard/astro-loader-youtube/pulls/21
Co-authored-by: Renovate Bot <[email protected]>
Co-committed-by: Renovate Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted This PR is accepted to contribute towards hacktoberfest pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants