feat: cleanup integration api#14446
Conversation
🦋 Changeset detectedLatest commit: e894dd5 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: integration
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
.changeset/cuddly-worlds-beam.md
Outdated
| ```diff | ||
| // my-integration.mjs | ||
| const integration = () => { | ||
| + let routes |
There was a problem hiding this comment.
This line is unaligned with the rest
| + let routes | |
| + let routes |
|
@florian-lefebvre I'm just curious about the changesets being for the specific integrations only. This removes some stuff (including the |
|
All integration authors are affected. I chose to scope the changesets to |
|
OK, yeah in that case this feels like a change to the Integrations API proper, and should be represented as an Astro change? (That just happens to affect some of our own existing official integrations) I'd only have ONE changeset, listing ALL the things removed from the Integrations API. And then have the multiple examples in the "what should I do?" |
|
Updated! |
|
lol, two changesets is fine! 😄 let me read them now! |
|
Yeah sorry, I kinda prefer 2 changesets for it |
sarah11918
left a comment
sarah11918
left a comment
There was a problem hiding this comment.
Just some tiny tiny bits of polishing suggestions, in part to make this extra super obvious that this affects Astro integrations only! But this is great!
Co-authored-by: Sarah Rainsberger <[email protected]>
4 participants
Changes
routesonastro:build:done#14444routesfromastro:build:doneentryPointsfromastro:build:ssras it was unused since the removal offunctionPerRouteIntegrationRouteDatatypeTesting
Updated
Docs
withastro/docs#12445