fix(svelte): detect Svelte components with renamed renderer prop#14433
Merged
Conversation
🦋 Changeset detectedLatest commit: b6627dd The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
florian-lefebvre
approved these changes
Sep 24, 2025
Merged
matthewp
pushed a commit
that referenced
this pull request
Jul 2, 2026
…rer` prop (#17270) Svelte renamed the internal renderer prop from `$$payload` to `$$renderer` in Svelte 5.x (#14433 fixed the Svelte renderer check). The Solid renderer copies that check to exclude Svelte components from being claimed as Solid, but was never updated to cover the new prop name. Projects that mix `@astrojs/solid-js` with `@astrojs/svelte` and use a newer Svelte 5 release now compile components with `$$renderer`, which the Solid renderer doesn't recognise, causing it to render those Svelte components as empty strings instead of passing them to the Svelte renderer. Fixes by mirroring the same two-prop check that the Svelte renderer already uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Svelte 5.39.1 changed the name of the
$$payloadprop. We were using this as a heuristic to detect if a component was svelte, meaning that we were no longer detecting it. This PR checks for both.Testing
Updated fixtures.
Docs