Merged
Conversation
|
github-actions
bot
added
the
pkg: astro
CodSpeed Performance ReportMerging #14405 will not alter performanceComparing Summary
Footnotes |
| internalURL: 'astro/compiler-runtime', | ||
| // TODO: this is no longer necessary for `Astro.site` | ||
| // but it somehow allows working around caching issues in content collections for some tests | ||
| astroGlobalArgs: JSON.stringify(astroConfig.site), |
Member
Author
There was a problem hiding this comment.
Looks like it's not relevant anymore with the content layer
ascorbic
approved these changes
Sep 19, 2025
aprici7y
added a commit
to aprici7y/astro
that referenced
this pull request
Oct 19, 2025
Restores the astroGlobalArgs compiler option that was removed in withastro#14405. This parameter is needed to pass the site config to the compiler so Astro.site is available in getStaticPaths().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Should pass
Docs
N/A, refactor