feat: add schema parsing to live collections#13763
Merged
Merged
Conversation
github-actions
Bot
added
pkg: astro
|
ascorbic
force-pushed
the
live-loader-schema
branch
from
May 7, 2025 10:24
32750ec to
375d854
Compare
ematipico
approved these changes
May 7, 2025
ematipico
left a comment
ematipico
left a comment
Member
There was a problem hiding this comment.
Left few questions around the code. It would be great if the RFC would cover error handling
|
|
||
| export function isAstroError(e: unknown): e is AstroError { | ||
| return e instanceof AstroError; | ||
| return e instanceof AstroError || AstroError.is(e); |
Contributor
Author
There was a problem hiding this comment.
When the AstroError is thrown inside the content config it's not recognising it as an instance of the AstroError class, so isn't giving the nicely-formatted error messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds schema parsing to live content collections.
getCollectionandgetEntryTesting
Still needs tests
Docs
Added a new error