Closed
Conversation
🦋 Changeset detectedLatest commit: 325ceac The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
Member
Author
|
Mostly blocked by a new version of tinyglobby, which is blocked by a new version of fdir, but anyways it might be easier to start the changes from scratch, so closing this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Replace
fast-globandglobbywithtinyglobby.Benefits:
Cons:
followSymbolicLinksoption is currently disabled and affects us globbing into symlinked directories, which I think could be an issue for content layer glob loader?Testing
Existing tests should pass. I also did some manual tests making sure the returned glob result matches the previous library we use, and that it's not globbing more files than needed.
Docs
n/a. internal change