fix: void elements#10493
Merged
lilnasy merged 3 commits intowithastro:mainfrom Mar 19, 2024
firefoxic:fix/void-elements
Merged
Conversation
HTML is not XML. It doesn't have self-closing tags, it has void element tags that don't need closing slashes. Now generated void elements (e.g. link with path to style file) do not pass validation, which can be easily fixed by simply removing two characters.
🦋 Changeset detectedLatest commit: 367f275 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
matthewp
approved these changes
Mar 19, 2024
Princesseuh
approved these changes
Mar 19, 2024
ematipico
approved these changes
Mar 19, 2024
lilnasy
reviewed
Mar 19, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
What does this change?
HTML is not XML. It doesn't have self-closing tags, it has void element tags that don't need closing slashes.
Generated void elements (e.g.
linkwith path to style file) do not pass validation, which can be easily fixed by simply removing two characters.FYI: https://jakearchibald.com/2023/against-self-closing-tags-in-html/
Before/after screenshots can help as well.
Don't forget a changeset!
pnpm exec changesetI'm not sure, but I hope I did it right.
Testing
I tested this change in my astro-project — it fixed the validity of the markup.
Docs
Correcting the documentation is most likely not necessary.