Skip to content

Commit 812658a

Browse files
bluwybluwy
authored
Remove shamefully-hoist (#4842)
1 parent f4bca41 commit 812658a

104 files changed

Lines changed: 768 additions & 527 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.changeset/itchy-guests-perform.md‎

Lines changed: 5 additions & 0 deletions

‎.changeset/odd-elephants-argue.md‎

Lines changed: 5 additions & 0 deletions

‎.changeset/silver-rats-know.md‎

Lines changed: 15 additions & 0 deletions

‎.changeset/young-pens-lick.md‎

Lines changed: 5 additions & 0 deletions

‎.github/workflows/ci.yml‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,8 +207,9 @@ jobs:
207207
repository: withastro/docs
208208
path: smoke/docs
209209

210+
# NOTE: remove shamefully-hoist when docs is also not hoisted
210211
- name: Install dependencies
211-
run: pnpm install --no-frozen-lockfile
212+
run: pnpm install --no-frozen-lockfile --shamefully-hoist
212213

213214
- name: Build Packages
214215
run: pnpm run build

‎.npmrc‎

Lines changed: 10 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -4,19 +4,13 @@ link-workspace-packages=true
44
save-workspace-protocol=false # This prevents the examples to have the `workspace:` prefix
55
auto-install-peers=false
66

7-
shamefully-hoist=true
8-
# TODO: We would like to move to individual opt-in hoisting, but Astro was not originally
9-
# written with this in mind. In the future, it would be good to hoist individual packages only.
10-
# public-hoist-pattern[]=autoprefixer
11-
# public-hoist-pattern[]=astro
12-
# public-hoist-pattern[]=remark-*
13-
# public-hoist-pattern[]=rehype-*
14-
# public-hoist-pattern[]=react
15-
# public-hoist-pattern[]=react-dom
16-
# public-hoist-pattern[]=preact
17-
# public-hoist-pattern[]=preact-render-to-string
18-
# public-hoist-pattern[]=vue
19-
# public-hoist-pattern[]=svelte
20-
# public-hoist-pattern[]=solid-js
21-
# public-hoist-pattern[]=lit
22-
# public-hoist-pattern[]=@webcomponents/template-shadowroot
7+
# `github-slugger` is used by `vite-plugin-markdown-legacy`.
8+
# Temporarily hoist this until we remove the feature.
9+
public-hoist-pattern[]=github-slugger
10+
# Vite's esbuild optimizer has trouble optimizing `@astrojs/lit/client-shim.js`
11+
# which imports this dependency.
12+
public-hoist-pattern[]=@webcomponents/template-shadowroot
13+
# On Windows, `svelte-preprocess` can't import `svelte/compiler`. Might be a pnpm bug.
14+
public-hoist-pattern[]=svelte
15+
# There's a lit dependency duplication somewhere causing multiple Lit versions error.
16+
public-hoist-pattern[]=*lit*

‎examples/basics/.npmrc‎

Lines changed: 0 additions & 2 deletions
This file was deleted.

‎examples/blog/.npmrc‎

Lines changed: 0 additions & 2 deletions
This file was deleted.

‎examples/deno/.npmrc‎

Lines changed: 0 additions & 2 deletions
This file was deleted.

‎examples/docs/.npmrc‎

Lines changed: 0 additions & 2 deletions
This file was deleted.

0 commit comments

Comments
 (0)