Fix support for .well-known and other routes with a leading .#88
Fix support for .well-known and other routes with a leading .#88delucis merged 7 commits intowithastro:mainfrom
.well-known and other routes with a leading .#88Conversation
Due to no longer supporting hidden files: actions/upload-pages-artifact#129 Hidden files are required for `/.well-known`.
|
Ah, damn, I didn't consider One big motivation for us upgrading is that earlier versions of Would you be interested in exploring what it would take to do this manually instead? |
|
Ah. I like to live dangerously, I guess. Probably the simplest thing is to just copy their action in line, and remove the offending part of the tar command that excludes hidden files. The PR has been updated to do this. I've tested it personally (against If this if too much code I am happy staying on an older version, though you may wish to document the loss of Hopefully at some point GitHub will ship a parameter that allows you to (selectively?) hidden files, and this will no longer be necessary. |
delucis
left a comment
delucis
left a comment
There was a problem hiding this comment.
Thanks @SCdF! Would definitely be preferable to not have to maintain this, but I’m happy for us to take it on for now. Nice work on the clear explanatory comment in the workflow file.
We can watch actions/upload-pages-artifact#129 and hopefully be able to switch back to the official action at some point 🤞
delucis
changed the title
.well-known and other routes with a leading .
2 participants
In 2226b56 upload-pages-artifact was updated to v4.
Unfortunately that version has a bug / bad feature, which blocks hidden files being added to the uploaded archive, which breaks
.well-known. See: actions/upload-pages-artifact#129You can see this by inspecting the archive generated by this action, and note that it won't contain hidden files.
This PR inlines the action that the upload pages artifact performs, but allows hidden files. This is the best we can do until github allows us to pass a parameter or similar.