Merged
Conversation
HiDeoo
approved these changes
Aug 30, 2025
Member
HiDeoo
left a comment
HiDeoo
left a comment
There was a problem hiding this comment.
Left a tiny suggestion but otherwise looks good to me 👍 (also tested the logic locally using a bash script)
Co-authored-by: HiDeoo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #80
This PR updates the action to check if a
packageManagerfield is present when someone is using PNPM. If it isn’t, https://github.com/pnpm/action-setup won’t be able to detect the version to use, so we set it tolatestand add a warning to the action run letting people know that an explicit version is recommended.