WPB-21917 [fix] GET /teams/:tid/channels/search results should be sorted case-insensitively
#4870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the channel search endpoint (GET /teams/:tid/channels/search) to sort results case-insensitively. Previously, channels were sorted alphabetically with case sensitivity (e.g., "Apple" before "banana"), which created inconsistent ordering. The fix ensures that sorting treats uppercase and lowercase letters equivalently (e.g., "Apple" and "apple" sort together alphabetically).
Key Changes
- Modified PostgreSQL queries to use
lower(name)in ORDER BY clauses for case-insensitive sorting - Updated pagination cursor logic to apply
Text.toLowerfor consistent case-insensitive comparisons - Added a database index on
(team, group_conv_type, lower(name), id)to optimize the case-insensitive queries - Refactored test helper to extract common channel configuration setup
- Added comprehensive integration test validating ascending and descending case-insensitive sort order
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
libs/wire-subsystems/src/Wire/ConversationStore/Postgres.hs |
Modified searchConversationsImpl to use lower(name) in ORDER BY clauses (both inner CTE and outer query) and updated pagination cursor comparison to use Text.toLower for consistency |
libs/wire-subsystems/postgres-migrations/20251121090452-conversation_team_group_type_lower_name_id_idx.sql |
Created database index on (team, group_conv_type, lower(name), id) to support efficient case-insensitive channel search queries |
integration/test/Test/ChannelSearch.hs |
Extracted channel config setup into a reusable helper function and added testChannelSearchSortCaseInsensitive test to verify case-insensitive sorting works correctly in both ascending and descending order |
changelog.d/3-bug-fixes/WPB-21917 |
Added changelog entry documenting the bug fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
battermann
deleted the
WPB-21917-get-teams-tid-channels-search-results-should-be-sorted-case-insensitive
branch
This was referenced Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-21917
Checklist
changelog.d