WPB-21392: change federation-not-implemented error status from 500 to 422
#4855
Conversation
zebot
added
the
ok-to-test
blackheaven
changed the title
federation-not-implemented erre status from 500 to 501federation-not-implemented error status from 500 to 501
blackheaven
force-pushed
the
gdifolco/WPB-21392-federation-not-implemented-error
branch
from
ba9953c to
585788c
Compare
yes, 422 is great. (with "sub-5xx error", i tried to mean something with status < 500, probably wasn't very clear...) |
fisx
changed the title
federation-not-implemented error status from 500 to 501federation-not-implemented error status from 500 to 422
| retry500Once action = do | ||
| action `bindResponse` \resp -> do | ||
| if resp.status == 500 | ||
| if resp.status == 500 || resp.status == 422 |
There was a problem hiding this comment.
Why are we retrying 422, not-implemented error won't go away with a retry right?
There was a problem hiding this comment.
good point! 400 then? or 404?
ah, saw it: we can keep the 422 status, but should remove the == 422 condition here, right?
There was a problem hiding this comment.
It'll break without it
There was a problem hiding this comment.
I guess, at the start of the test, for a little while, all federation is not properly setup
There was a problem hiding this comment.
in that case i wouldn't worry too much about it. leave it in!
blackheaven
force-pushed
the
gdifolco/WPB-21392-federation-not-implemented-error
branch
from
96413e5 to
0bf6a39
Compare
https://wearezeta.atlassian.net/browse/WPB-21392
Checklist
changelog.d@fisx in the issue you have mentioned a sub-5xx error, but monitoring could filter-out 501.
I can also change it to 422 if you prefer.