Skip to content

Conversation

@battermann
Copy link
Contributor

@battermann battermann commented Nov 4, 2025

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Nov 4, 2025
@battermann battermann marked this pull request as ready for review November 4, 2025 11:22
@battermann battermann requested review from a team as code owners November 4, 2025 11:22
@battermann battermann requested a review from Copilot November 4, 2025 11:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR relocates the /teams/:tid/channels/search endpoint configuration from the brig upstream service to the galley upstream service in the nginz routing configuration. The change reflects that the channel search functionality is actually implemented in galley rather than brig.

Key changes:

  • Moved the /teams/([^/]*)/channels/search$ path configuration from brig to galley section
  • Updated the changelog entry to include PR reference numbers

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
charts/nginz/values.yaml Relocated the /teams/([^/]*)/channels/search$ endpoint configuration from the brig upstream section to the galley upstream section
changelog.d/2-features/channel-search Added PR reference numbers (#4821, #4836) to the changelog entry

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops.

@battermann battermann merged commit 6744b74 into develop Nov 4, 2025
15 checks passed
@battermann battermann deleted the battermann/fix-nginz-values-for-channels-search branch November 4, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants