WPB-20764 add user group ids to team member search result #4809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
battermann
changed the title
blackheaven
approved these changes
Oct 9, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds user group IDs to team member search results, enabling clients to determine which user groups each team member belongs to when browsing team contacts.
- Add user group IDs to the TeamContact data structure and search response
- Implement database and in-memory retrieval of user group memberships for team members
- Update test fixtures and add integration test to verify the functionality
Reviewed Changes
Copilot reviewed 45 out of 47 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/wire-api/src/Wire/API/User/Search.hs | Add user_groups field to TeamContact API |
| libs/wire-subsystems/src/Wire/UserSearch/Types.hs | Update userDocToTeamContact to accept user groups parameter |
| libs/wire-subsystems/src/Wire/UserSubsystem/Interpreter.hs | Fetch user group IDs and pass to contact conversion |
| libs/wire-subsystems/src/Wire/UserGroupStore.hs | Add GetUserGroupIds operation to store interface |
| libs/wire-subsystems/src/Wire/UserGroupStore/Postgres.hs | Implement PostgreSQL query for user group membership |
| libs/wire-subsystems/test/unit/Wire/MockInterpreters/UserGroupStore.hs | Add in-memory implementation for tests |
| libs/wire-subsystems/test/unit/Wire/MiniBackend.hs | Wire up user group store in test backend |
| integration/test/Test/Search.hs | Add integration test verifying user groups in search results |
| changelog.d/2-features/WPB-20764 | Add changelog entry |
| Multiple golden test files | Update test fixtures with empty user_groups array |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
libs/wire-subsystems/test/unit/Wire/MockInterpreters/UserGroupStore.hs
Outdated
Show resolved
Hide resolved
akshaymankar
requested changes
Oct 9, 2025
battermann
force-pushed
the
WPB-20764-add-user-groups-property-for-users
branch
from
6b08bdc to
0cdddd4
Compare
akshaymankar
requested changes
Oct 9, 2025
This was referenced Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-20764
Checklist
changelog.d