add nginz rules for missing endpoints #4808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds nginx routing rules for two previously uncovered API endpoints in the nginz configuration. The changes ensure proper routing for team collaboration and app cookie management endpoints.
Key changes:
- Added routing rule for team collaborator deletion endpoint
- Added routing rule for team app cookies endpoint
- Added changelog entry documenting the bug fix
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| charts/nginz/values.yaml | Added two new path rules for /teams/:tid/collaborators/:uid and /teams/:tid/apps/:app/cookies endpoints |
| changelog.d/3-bug-fixes/nginz-rules | Added changelog entry for the nginx rules addition |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
eyeinsky
approved these changes
Oct 10, 2025
supersven
reviewed
Oct 10, 2025
supersven
approved these changes
Oct 10, 2025
battermann
force-pushed
the
battermann/fix-nginz-rules
branch
from
1f3c159 to
f61d8b0
Compare
This was referenced Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following endpoints were not covered before:
POST /teams/:tid/apps/:app/cookiesDELETE /teams/:tid/collaborators/:uidChecklist
changelog.d