Group info diagnostics #4788
Merged
Group info diagnostics #4788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
pcapriotti
force-pushed
the
mls-group-info-check-flag
branch
3 times, most recently
from
a45c77a to
57a48ba
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the generic MLSGroupInfoMismatch error with detailed GroupInfoDiagnostics to provide more informative error responses when MLS group info validation fails. It also adds a team-level feature flag to control when group info diagnostics are enabled.
- Replaced
MLSGroupInfoMismatcherror withGroupInfoDiagnosticscontaining detailed information (commit, group info, clients, etc.) - Added
mlsGroupInfoDiagnosticsfield to the MLS feature configuration for per-team control - Updated error handling across MLS message processing and federation APIs
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| services/galley/src/Galley/API/MLS/GroupInfoCheck.hs | New module implementing group info validation with detailed error reporting |
| services/galley/src/Galley/API/MLS/Message.hs | Updated MLS message processing to use new group info diagnostics |
| libs/wire-api/src/Wire/API/Error/Galley.hs | Added GroupInfoDiagnostics error type and removed MLSGroupInfoMismatch |
| libs/wire-api/src/Wire/API/Team/Feature.hs | Added mlsGroupInfoDiagnostics field to MLS feature configuration |
| libs/wire-api/src/Wire/API/Team/Member/Error.hs | New module for team member permission error handling |
| integration/test/Test/MLS.hs | Updated test to use new diagnostics response format |
| Multiple test files | Updated to include groupInfoDiagnostics field in MLS configurations |
Comments suppressed due to low confidence (2)
services/galley/src/Galley/API/MLS/Message.hs:1
- This import is removed but
viewis still used on line 85 in the new GroupInfoCheck module. Verify that the import has been moved to the appropriate location.
-- This file is part of the Wire Server implementation.
integration/test/Testlib/Assertions.hs:1
- The function signature change from
shouldMatchBase64 a btoshouldMatchBase64 a bytestringis a breaking change. The parameterbis now expected to be raw bytes instead of a MakesValue, which changes the API contract.
{-# LANGUAGE CPP #-}
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
15
to
24
| .= object | ||
| ["mlsConversationReset" .= True] | ||
| ] | ||
| defSetting = | ||
| object | ||
| [ "status" .= "enabled", | ||
| "config" .= object ["mlsConversationReset" .= False] | ||
| "config" | ||
| .= object | ||
| [ "mlsConversationReset" .= False | ||
| ] |
There was a problem hiding this comment.
[nitpick] The formatting change breaks the object construction across multiple lines unnecessarily. Keep the original compact format for consistency with similar patterns in the codebase.
This reverts commit e5a1534.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
pcapriotti
force-pushed
the
mls-group-info-check-flag
branch
from
00c68cb to
6c3911f
Compare
stefanwire
approved these changes
Oct 23, 2025
This was referenced Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-20339
Checklist
changelog.d