Skip to content

Conversation

@battermann
Copy link
Contributor

@battermann battermann commented Sep 17, 2025

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@battermann battermann marked this pull request as ready for review September 17, 2025 14:49
@battermann battermann requested review from a team as code owners September 17, 2025 14:49
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Sep 17, 2025
@supersven supersven requested a review from Copilot September 17, 2025 15:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new feature flag AssetAuditLog to the Wire server codebase. The feature flag is designed to be global and immutable, with no configuration payload and always locked status.

  • Implements AssetAuditLogConfig feature flag infrastructure across the API and type system
  • Adds configuration support in Helm charts and deployment files
  • Includes comprehensive test coverage for the new feature flag

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
libs/wire-api/src/Wire/API/Team/Feature.hs Defines the AssetAuditLogConfig type and implements required feature interfaces
services/galley/src/Galley/API/Teams/Features/Get.hs Adds GetFeatureConfig instance for AssetAuditLogConfig
services/galley/src/Galley/API/Public/Feature.hs Registers the feature in the public API routing
libs/wire-api/src/Wire/API/Routes/Public/Galley/Feature.hs Adds FeatureAPIGet route for AssetAuditLogConfig
services/galley/src/Galley/API/Internal.hs Adds internal API support for the feature
libs/wire-api/src/Wire/API/Routes/Internal/Galley.hs Defines internal feature API routing for AssetAuditLogConfig
libs/galley-types/src/Galley/Types/Teams.hs Implements FeatureDefaults for AssetAuditLogConfig
integration/test/Test/FeatureFlags/AssetAuditLog.hs Comprehensive test suite for the new feature flag
integration/test/Test/FeatureFlags/Util.hs Updates test utilities to include the new feature
integration/integration.cabal Registers the new test module
services/galley/galley.integration.yaml Adds integration test configuration
hack/helm_vars/wire-server/values.yaml.gotmpl Updates Helm template values
charts/galley/values.yaml Adds default configuration values
charts/galley/templates/configmap.yaml Updates Helm template to include the feature
docs/src/developer/reference/config-options.md Documents the new feature flag
changelog.d/2-features/WPB-20206 Adds changelog entry

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@supersven
Copy link
Contributor

@copilot why haven't you approved this PR?

@battermann battermann merged commit d7f6bb3 into develop Sep 17, 2025
9 checks passed
@battermann battermann deleted the WPB-20206-create-a-new-feature-flag-asset-audit-log branch September 17, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants