WPB-19713: Implement channels and channelsCount in user-groups endpoints
#4776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
blackheaven
force-pushed
the
gdifolco/WPB-19713_user-groups-channels-list
branch
2 times, most recently
from
228209f to
e9cf397
Compare
blackheaven
changed the base branch from
develop
to
gdifolco/WPB-19712_user-groups-update-endpoint
blackheaven
force-pushed
the
gdifolco/WPB-19713_user-groups-channels-list
branch
from
e9cf397 to
4a6c392
Compare
blackheaven
force-pushed
the
gdifolco/WPB-19713_user-groups-channels-list
branch
from
1dbdc78 to
bd253ff
Compare
blackheaven
force-pushed
the
gdifolco/WPB-19713_user-groups-channels-list
branch
2 times, most recently
from
c325bbe to
c71074e
Compare
blackheaven
force-pushed
the
gdifolco/WPB-19712_user-groups-update-endpoint
branch
from
4ed864c to
909912b
Compare
blackheaven
force-pushed
the
gdifolco/WPB-19713_user-groups-channels-list
branch
from
c71074e to
b4af1e1
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements the channels and channelsCount fields in user-groups endpoints, addressing ticket WPB-19713. The implementation adds functionality to fetch and include channel information when retrieving user groups.
Key changes:
- Add
ListChannelsoperation to retrieve channels associated with user groups - Implement conditional channel fetching based on
include_channelsquery parameter - Update API routes and test coverage for the new functionality
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| services/brig/src/Brig/API/Public.hs | Implements channel fetching logic in getUserGroup and getUserGroups handlers |
| services/brig/default.nix | Adds vector dependency for channel count calculations |
| services/brig/brig.cabal | Adds vector library dependency |
| postgres-schema.sql | Contains duplicate table definition (appears to be unintentional) |
| libs/wire-subsystems/test/unit/Wire/MockInterpreters/UserGroupStore.hs | Implements mock interpreter for ListUserGroupChannels |
| libs/wire-subsystems/src/Wire/UserGroupSubsystem/Interpreter.hs | Adds listChannels function with proper authorization checks |
| libs/wire-subsystems/src/Wire/UserGroupSubsystem.hs | Defines ListChannels operation in the subsystem interface |
| libs/wire-subsystems/src/Wire/UserGroupStore/Postgres.hs | Implements PostgreSQL query for listing user group channels |
| libs/wire-subsystems/src/Wire/UserGroupStore.hs | Adds ListUserGroupChannels to the store interface |
| libs/wire-api/src/Wire/API/Routes/Public/Brig.hs | Updates API documentation and adds include_channels query parameter |
| integration/test/Test/UserGroup.hs | Updates test to verify channel inclusion functionality |
| integration/test/API/Brig.hs | Adds helper function for testing channel inclusion |
| changelog.d/2-features/WPB-19713 | Documents the feature addition |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
blackheaven
force-pushed
the
gdifolco/WPB-19712_user-groups-update-endpoint
branch
from
db1b267 to
2dea4d2
Compare
battermann
force-pushed
the
gdifolco/WPB-19713_user-groups-channels-list
branch
from
0823403 to
2b3d03e
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
libs/wire-subsystems/test/unit/Wire/MockInterpreters/UserGroupStore.hs
Outdated
Show resolved
Hide resolved
libs/wire-subsystems/test/unit/Wire/MockInterpreters/UserGroupStore.hs
Outdated
Show resolved
Hide resolved
battermann
approved these changes
Oct 8, 2025
Contributor
battermann
left a comment
battermann
left a comment
There was a problem hiding this comment.
There is one todo left in the code which should be resolved otherwise this looks good to me.
| delete from user_group_member where user_group_id = ($1 :: uuid) | ||
| |] | ||
|
|
||
| -- TODO: move to a shared place |
Contributor
There was a problem hiding this comment.
we still need to resolve this TODO
Base automatically changed from
gdifolco/WPB-19712_user-groups-update-endpoint
to
develop
October 8, 2025 14:37
Co-authored-by: Copilot <[email protected]>
This reverts commit 6985978.
blackheaven
force-pushed
the
gdifolco/WPB-19713_user-groups-channels-list
branch
from
dc981e3 to
5aa333d
Compare
This was referenced Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-19713
Checklist
changelog.dWIP
Design considerations
I'm not happy with the design, I can either:
GalleyAPIAccesschannels/channelsCountfrom the effect