Skip to content

WPB-19693 fix role filter in team search endpoint #4728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
battermann merged 16 commits into from
Sep 16, 2025
Merged

WPB-19693 fix role filter in team search endpoint #4728

battermann merged 16 commits into from
Sep 16, 2025

Conversation

@battermann
Copy link
Contributor

@battermann battermann commented Aug 25, 2025 •
edited
Loading

https://wearezeta.atlassian.net/browse/WPB-19693

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Aug 25, 2025
@battermann battermann marked this pull request as ready for review September 10, 2025 13:46
@battermann battermann requested review from a team as code owners September 10, 2025 13:46
@battermann battermann force-pushed the WPB-19693-fix-role-filter-in-team-search-endpoint branch from baf251a to 294c573 Compare September 10, 2025 13:48
@eyeinsky
Copy link
Contributor

eyeinsky commented Sep 11, 2025

This looks good to me! The tests are also easy to read for someone new to the codebase. :)

Just two questions to improve my understanding:

  • was the bug in the instance FromHttpApiData Role than needed an explicit mapping?
  • is the search index update related to the bug fix? I guess if it is then the index is updated before the search happens, but I can't find this relation in the code, I guess it was already present before the changes in this PR?

@eyeinsky
Copy link
Contributor

eyeinsky commented Sep 11, 2025

Also, I guess the https://wearezeta.atlassian.net/browse/WPB-11124 ticket can be closed now.

@battermann
Copy link
Contributor Author

battermann commented Sep 11, 2025

Also, I guess the https://wearezeta.atlassian.net/browse/WPB-11124 ticket can be closed now.

yes when this is merged

@battermann
Copy link
Contributor Author

battermann commented Sep 11, 2025

This looks good to me! The tests are also easy to read for someone new to the codebase. :)

Just two questions to improve my understanding:

  • was the bug in the instance FromHttpApiData Role than needed an explicit mapping?
  • is the search index update related to the bug fix? I guess if it is then the index is updated before the search happens, but I can't find this relation in the code, I guess it was already present before the changes in this PR?

Actually, it is/was all:

  • the parser didn't work
  • the field in the index was neither set nor updated
  • the role filter was ignored when doing queries.

@battermann battermann force-pushed the WPB-19693-fix-role-filter-in-team-search-endpoint branch from bafb91c to 7f3fce4 Compare September 12, 2025 14:36
akshaymankar
akshaymankar requested changes Sep 15, 2025
View reviewed changes
Copy link
Member

@akshaymankar akshaymankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think force updating on normal updates is not good when we can compute the write time of the role of the user.

@battermann battermann mentioned this pull request Sep 15, 2025
Merged
2 tasks
akshaymankar
akshaymankar approved these changes Sep 16, 2025
View reviewed changes
Copy link
Member

@akshaymankar akshaymankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :shipit:

@battermann battermann merged commit 18885bc into develop Sep 16, 2025
8 checks passed
@battermann battermann deleted the WPB-19693-fix-role-filter-in-team-search-endpoint branch September 16, 2025 07:48
This was referenced Oct 20, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akshaymankar akshaymankar akshaymankar approved these changes

+1 more reviewer

@eyeinsky eyeinsky eyeinsky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@battermann @eyeinsky @akshaymankar @zebot