Skip to content

WPB-19234: Allow team admins to bulk add users to user groups #4712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blackheaven merged 8 commits into from
Aug 28, 2025
Merged

WPB-19234: Allow team admins to bulk add users to user groups #4712

blackheaven merged 8 commits into from
Aug 28, 2025

Conversation

@blackheaven
Copy link
Contributor

@blackheaven blackheaven commented Aug 13, 2025

https://wearezeta.atlassian.net/browse/WPB-19234

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@blackheaven blackheaven self-assigned this Aug 13, 2025
@blackheaven blackheaven requested review from a team as code owners August 13, 2025 11:01
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Aug 13, 2025
@blackheaven
Copy link
Contributor Author

blackheaven commented Aug 13, 2025

The usual failing test:

[wire-server-enterprise@dynamic-backend-1.test-dk5d8go6lt1u.svc.cluster.local:Auth.testTooManyCookies] {"level":"Info","msgs":["Listening on 127.0.0.1:10079"]}

@blackheaven blackheaven force-pushed the gdifolco/WPB-19234_add-users-bulk branch from afab4cf to 31052f5 Compare August 13, 2025 13:01
@blackheaven
Copy link
Contributor Author

blackheaven commented Aug 13, 2025

TODO

This is trivial, but I think it would be nice to test that non-team members and non-admins cannot add users to a user group, as well as the correct notifications are sent to users and admins.

@blackheaven
Copy link
Contributor Author

blackheaven commented Aug 18, 2025

@battermann can you have another look please? I have added test for edge cases and notifications.

@blackheaven blackheaven force-pushed the gdifolco/WPB-19234_add-users-bulk branch from a888e55 to 2688db5 Compare August 28, 2025 07:26
@blackheaven
Copy link
Contributor Author

blackheaven commented Aug 28, 2025

Needs #4734 to be merged first

@blackheaven blackheaven force-pushed the gdifolco/WPB-19234_add-users-bulk branch from 0823c85 to 7f38d7f Compare August 28, 2025 09:16
@blackheaven blackheaven force-pushed the gdifolco/WPB-19234_add-users-bulk branch from 7f38d7f to 1ec987f Compare August 28, 2025 09:42
battermann
battermann approved these changes Aug 28, 2025
View reviewed changes
Copy link
Contributor

@battermann battermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blackheaven blackheaven merged commit dcbbb2f into develop Aug 28, 2025
8 checks passed
@blackheaven blackheaven deleted the gdifolco/WPB-19234_add-users-bulk branch August 28, 2025 14:52
@zebot zebot mentioned this pull request Sep 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@battermann battermann battermann approved these changes

Assignees

@blackheaven blackheaven

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@blackheaven @battermann @zebot