Fix conversation type check for reset action #4702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all actions apply only to group conversations. Before, we had an explicit exception for rename actions, but the reset action also should apply to all types. This extends the check logic by taking the action tag into account.
zebot
added
the
ok-to-test
akshaymankar
approved these changes
Aug 5, 2025
blackheaven
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the backend was incorrectly checking that a conversation being reset is a group conversation, and throwing "invalid-op" if not.
https://wearezeta.atlassian.net/browse/WPB-19296
Checklist
changelog.d