fix(nginz): also include namespace in upstream name when upstream_namespace is set
#4701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
mastaab
approved these changes
Aug 4, 2025
wartraxx51
approved these changes
Aug 4, 2025
…mespace` is set related to WPB-19292
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
upstream_nameis set, we're including it in the proxy_pass directive. However, the actual upstreams never included the namespace name.This PR adds the namespace to the upstream name in the upstream declaration, so that proxy_pass is not running into a 504 error for such services.
related to WPB-19292
Checklist
changelog.d