WPB-18191: Add route to collaborator permissions from team #4697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackheaven
changed the base branch from
develop
to
gdifolco/WPB-18190_collaborator-delete-endpoint
zebot
added
the
ok-to-test
blackheaven
commented
Jul 31, 2025
Contributor
Author
There was a problem hiding this comment.
blackheaven
force-pushed
the
gdifolco/WPB-18191_collaborator-update-endpoint
branch
2 times, most recently
from
689dd19 to
252bc04
Compare
blackheaven
changed the title
blackheaven
force-pushed
the
gdifolco/WPB-18191_collaborator-update-endpoint
branch
from
252bc04 to
ae16812
Compare
blackheaven
force-pushed
the
gdifolco/WPB-18190_collaborator-delete-endpoint
branch
from
8e873f3 to
78aea4e
Compare
blackheaven
force-pushed
the
gdifolco/WPB-18191_collaborator-update-endpoint
branch
from
ae16812 to
a2cfeab
Compare
blackheaven
force-pushed
the
gdifolco/WPB-18191_collaborator-update-endpoint
branch
from
a2cfeab to
a423074
Compare
blackheaven
force-pushed
the
gdifolco/WPB-18190_collaborator-delete-endpoint
branch
from
83eb7a1 to
c1f5acf
Compare
blackheaven
force-pushed
the
gdifolco/WPB-18191_collaborator-update-endpoint
branch
from
4fa59cc to
7a2e3ff
Compare
Contributor
Author
|
I cannot reproduce the error, which seems not related to my changes. |
blackheaven
force-pushed
the
gdifolco/WPB-18190_collaborator-delete-endpoint
branch
from
c1f5acf to
0969d6d
Compare
blackheaven
force-pushed
the
gdifolco/WPB-18191_collaborator-update-endpoint
branch
from
7a2e3ff to
607cfcf
Compare
blackheaven
force-pushed
the
gdifolco/WPB-18190_collaborator-delete-endpoint
branch
from
c5e0a60 to
30c92d0
Compare
blackheaven
force-pushed
the
gdifolco/WPB-18191_collaborator-update-endpoint
branch
from
607cfcf to
7d0a8c3
Compare
Contributor
Author
|
Does not seem related
|
blackheaven
force-pushed
the
gdifolco/WPB-18190_collaborator-delete-endpoint
branch
from
32ad69b to
3160115
Compare
blackheaven
force-pushed
the
gdifolco/WPB-18191_collaborator-update-endpoint
branch
2 times, most recently
from
8d1a9b6 to
aa0dcda
Compare
blackheaven
force-pushed
the
gdifolco/WPB-18190_collaborator-delete-endpoint
branch
2 times, most recently
from
5eb2959 to
c510050
Compare
blackheaven
force-pushed
the
gdifolco/WPB-18191_collaborator-update-endpoint
branch
from
aa0dcda to
280606b
Compare
blackheaven
force-pushed
the
gdifolco/WPB-18190_collaborator-delete-endpoint
branch
from
741ffd8 to
0ec3937
Compare
blackheaven
force-pushed
the
gdifolco/WPB-18191_collaborator-update-endpoint
branch
3 times, most recently
from
bea7d22 to
f114414
Compare
fisx
reviewed
Sep 12, 2025
blackheaven
force-pushed
the
gdifolco/WPB-18190_collaborator-delete-endpoint
branch
2 times, most recently
from
6ab2eaa to
9986c2f
Compare
Base automatically changed from
gdifolco/WPB-18190_collaborator-delete-endpoint
to
develop
September 24, 2025 10:16
blackheaven
force-pushed
the
gdifolco/WPB-18191_collaborator-update-endpoint
branch
from
b2a155d to
be7caa9
Compare
blackheaven
force-pushed
the
gdifolco/WPB-18191_collaborator-update-endpoint
branch
4 times, most recently
from
d19e72b to
3bb74ac
Compare
blackheaven
force-pushed
the
gdifolco/WPB-18191_collaborator-update-endpoint
branch
from
3bb74ac to
143bc42
Compare
fisx
reviewed
Nov 12, 2025
fisx
reviewed
Nov 12, 2025
Comment on lines
+1333
to
+1352
| P.debug $ | ||
| Log.field "targets" (toByteString rusr) | ||
| . Log.field "action" (Log.val "Teams.updateTeamCollaborator") | ||
| zusrMember <- E.getTeamMember tid (tUnqualified lusr) | ||
| void $ permissionCheck UpdateTeamCollaborator zusrMember | ||
| when (Set.null $ Set.intersection (Set.fromList [Collaborator.CreateTeamConversation, Collaborator.ImplicitConnection]) perms) $ | ||
| removeFromConvsAndPushConvLeaveEvent lusr Nothing tid rusr |
Contributor
There was a problem hiding this comment.
why are these things happening in galley, not in wire-subsystems? (i'm ok with leaving it here, especially if the answer is "we'd have to make major modifications to some canonical interpreters if we don't leave this here. just curious.)
Contributor
Author
There was a problem hiding this comment.
IIRC, we discussed with Leif months ago, but we can move it, where should it goes?
Contributor
There was a problem hiding this comment.
just into removeFromConvsAndPushConvLeaveEvent? but as i said, it may be a lot of work, in that case please don't.
blackheaven
force-pushed
the
gdifolco/WPB-18191_collaborator-update-endpoint
branch
from
a94d77e to
6ae4d69
Compare
Co-authored-by: Matthias Fischmann <[email protected]>
blackheaven
force-pushed
the
gdifolco/WPB-18191_collaborator-update-endpoint
branch
from
6ae4d69 to
0c12d7a
Compare
fisx
approved these changes
Nov 13, 2025
blackheaven
deleted the
gdifolco/WPB-18191_collaborator-update-endpoint
branch
This was referenced Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-18191
Checklist
changelog.d