Skip to content

WPB-18444 Federator logging errors on requests that seem to succeed #4672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fisx merged 3 commits into from
Jul 21, 2025
Merged

WPB-18444 Federator logging errors on requests that seem to succeed #4672

fisx merged 3 commits into from
Jul 21, 2025

Conversation

@battermann
Copy link
Contributor

@battermann battermann commented Jul 18, 2025 •
edited
Loading

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@battermann battermann marked this pull request as ready for review July 18, 2025 15:44
@battermann battermann requested review from a team as code owners July 18, 2025 15:44
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jul 18, 2025
fisx
fisx approved these changes Jul 21, 2025
View reviewed changes
@fisx fisx merged commit 944e067 into develop Jul 21, 2025
8 checks passed
@fisx fisx deleted the WPB-18444-federator-logging-errors-on-requests-that-seem-to-succeed branch July 21, 2025 12:44
@zebot zebot mentioned this pull request Jul 28, 2025
Merged
@eyeinsky
Copy link
Contributor

eyeinsky commented Aug 27, 2025

@battermann Do you remember any details regarding these log messages?

The federator CPU issue might be related to the event of what is being logged. There seemed to be two log messages per error: one of it was a multiline json message reporting a HTTP 500; the second was a more haskelly one line saying KilledByHttp2ThreadManager (Just ConnectionIsClosed).

@battermann
Copy link
Contributor Author

battermann commented Aug 27, 2025

@battermann Do you remember any details regarding these log messages?

The federator CPU issue might be related to the event of what is being logged. There seemed to be two log messages per error: one of it was a multiline json message reporting a HTTP 500; the second was a more haskelly one line saying KilledByHttp2ThreadManager (Just ConnectionIsClosed).

No there was nothing else logged except 500 server-error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fisx fisx fisx approved these changes

@stefanwire stefanwire stefanwire approved these changes

Assignees

No one assigned

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@battermann @eyeinsky @fisx @stefanwire @zebot