Skip to content

Conversation

@akshaymankar
Copy link
Member

https://wearezeta.atlassian.net/browse/WPB-17867

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@akshaymankar akshaymankar requested review from a team as code owners July 10, 2025 10:09
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jul 10, 2025
Copy link
Contributor

@battermann battermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix makes sense, and the test too. What I cannot assess is if the mock interpreter for the user index behaves the same as the real user index. I trust your expertise here.

Personally, I would have reproduced the issue with an integration test and then fix it. But the unit test has a much better resource footprint of course, that is nice.

@akshaymankar
Copy link
Member Author

The fix makes sense, and the test too. What I cannot assess is if the mock interpreter for the user index behaves the same as the real user index. I trust your expertise here.

Personally, I would have reproduced the issue with an integration test and then fix it. But the unit test has a much better resource footprint of course, that is nice.

I don't think it would behave exactly like elasticsearch, but I tried to encode the important parts of our query to ES. The way ES actually orders things is way more complicated and probably not worth replicating because from Wire's perspective the order of results doesn't matter so much.

@akshaymankar akshaymankar merged commit 0909c56 into develop Jul 10, 2025
8 checks passed
@akshaymankar akshaymankar deleted the dedup-search-results branch July 10, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants