Skip to content

background-worker/dead-user-notifs-watcher: Reconnect when connection with RabbitMQ is broken #4652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akshaymankar merged 15 commits into from
Jul 10, 2025
Merged

background-worker/dead-user-notifs-watcher: Reconnect when connection with RabbitMQ is broken #4652

akshaymankar merged 15 commits into from
Jul 10, 2025

Conversation

@akshaymankar
Copy link
Member

@akshaymankar akshaymankar commented Jul 8, 2025 •
edited
Loading

https://wearezeta.atlassian.net/browse/WPB-18631

Alternative approach for #4632 (Test is copied from there).

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@akshaymankar akshaymankar mentioned this pull request Jul 8, 2025
Closed
3 tasks
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jul 8, 2025
@akshaymankar akshaymankar marked this pull request as ready for review July 9, 2025 11:00
@akshaymankar akshaymankar requested review from a team as code owners July 9, 2025 11:00
supersven
supersven reviewed Jul 9, 2025
View reviewed changes
supersven
supersven reviewed Jul 9, 2025
View reviewed changes
supersven
supersven reviewed Jul 9, 2025
View reviewed changes
supersven
supersven reviewed Jul 9, 2025
View reviewed changes
supersven
supersven approved these changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@akshaymankar akshaymankar merged commit 3b49b4a into develop Jul 10, 2025
7 checks passed
@akshaymankar akshaymankar deleted the dead-user-notifs-reconnect branch July 10, 2025 10:03
@zebot zebot mentioned this pull request Jul 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@supersven supersven supersven approved these changes

Assignees

No one assigned

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@akshaymankar @supersven @zebot