Skip to content

WPB-18478 Fix false positive warning: attempt to send notification about conversation update to users not in the conversation #4644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
battermann merged 3 commits into from
Jul 7, 2025
Merged

WPB-18478 Fix false positive warning: attempt to send notification about conversation update to users not in the conversation #4644

battermann merged 3 commits into from
Jul 7, 2025

Conversation

@battermann
Copy link
Contributor

@battermann battermann commented Jul 3, 2025 •
edited
Loading

https://wearezeta.atlassian.net/browse/WPB-18478

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@battermann battermann marked this pull request as ready for review July 3, 2025 15:05
@battermann battermann requested review from a team as code owners July 3, 2025 15:05
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jul 3, 2025
pcapriotti
pcapriotti approved these changes Jul 4, 2025
View reviewed changes
Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@battermann battermann merged commit 7d26c89 into develop Jul 7, 2025
8 checks passed
@battermann battermann deleted the WPB-18478-attempt-to-send-notification-about-conversation-update-to-users-not-in-the-conversation branch July 7, 2025 13:43
This was referenced Jul 8, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcapriotti pcapriotti pcapriotti approved these changes

Assignees

No one assigned

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@battermann @pcapriotti @zebot