gundeck: Send push notifications to clients with consumable-notifications capability
#4626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests now fail correctly because gundeck is not sending native pushes to clients with consumable-notifications capability
…tions` capability
zebot
added
the
ok-to-test
Also create pushes with no recipients, as that is valid too in case an event is only meant for cells.
supersven
reviewed
Jun 25, 2025
supersven
reviewed
Jun 25, 2025
| handlePushCass Push {..} = do | ||
| forM_ _pushRecipients $ \(Recipient uid _ cids) -> do | ||
| clients <- Set.toList . Set.unions . Map.elems . (.userClientsFull) <$> mpaGetClients (Set.singleton uid) | ||
| let consumabeNotifClients = map (.clientId) $ filter supportsConsumableNotifications clients |
Contributor
There was a problem hiding this comment.
Suggested change
| let consumabeNotifClients = map (.clientId) $ filter supportsConsumableNotifications clients | |
| let consumableNotifClients = map (.clientId) $ filter supportsConsumableNotifications clients |
Typo.
supersven
reviewed
Jun 25, 2025
supersven
reviewed
Jun 25, 2025
supersven
requested changes
Jun 25, 2025
This was referenced Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-18369
Checklist
changelog.d