Add TeamId to conversation.delete event #4618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
Delete unused ConversationDelete type.
battermann
requested changes
Jun 18, 2025
| ConversationAction tag -> | ||
| Sem r LocalConversationUpdate | ||
| updateLocalConversationUnchecked lconv qusr con action = do | ||
| updateLocalConversationUnchecked lconv qusr con tid action = do |
Contributor
There was a problem hiding this comment.
I would prefer to use the team ID from the metadata of the Conversation value that is passed here. So that we do not have to thread the tid value through all the way from the deleteTeamConverstion handler. That would be less noisy and potentially reduce merge conflicts.
Contributor
Author
There was a problem hiding this comment.
Thanks for the hint! (I wasn't aware that the TeamID is there as well) 👍
Contributor
Author
There was a problem hiding this comment.
I've adjusted the code now accordingly.
Co-authored-by: Leif Battermann <[email protected]>
This avoids handing a separate TeamId argument around.
battermann
approved these changes
Jun 18, 2025
This was referenced Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
TeamIdto the payload ofconversation.deleteevents. The field'spath is
data.teamId.This should be fully backwards compatible: Older consumers can simply ignore this field.
I'm a bit uncertain about the name of the field
teamId. Wouldteambe better? 🤔Ticket: https://wearezeta.atlassian.net/browse/WPB-17738
Checklist
changelog.d