Skip to content

Conversation

@battermann
Copy link
Contributor

@battermann battermann commented Jun 13, 2025

https://wearezeta.atlassian.net/browse/WPB-17737

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@battermann battermann marked this pull request as ready for review June 13, 2025 13:45
@battermann battermann requested review from a team as code owners June 13, 2025 13:45
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jun 13, 2025
Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced that we need an ad-hoc mechanism for this event here. Couldn't we extend the normal FeatureConfig.Event logic to optionally send events to cells just like we have done for conversation events?

@battermann battermann requested a review from pcapriotti June 13, 2025 14:07
@battermann battermann merged commit 901a315 into develop Jun 16, 2025
8 checks passed
@battermann battermann deleted the WPB-17737-send-an-event-to-rabbit-mq-cells-bus-when-the-cells-feature-flag-is-enabled-on-a-team branch June 16, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants