Skip to content

Conversation

@stefanwire
Copy link
Contributor

@stefanwire stefanwire commented May 14, 2025

https://wearezeta.atlassian.net/browse/WPB-17585
https://wearezeta.atlassian.net/browse/WPB-17655

for reviewers: the interesting 10 lines are in the beginning of the Hack module.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label May 14, 2025
@stefanwire stefanwire force-pushed the WPB-17655-fix-saml-auth-resp-parsing branch from 50beb06 to 110410f Compare May 14, 2025 13:47
@fisx fisx force-pushed the WPB-17655-fix-saml-auth-resp-parsing branch 2 times, most recently from d2b9f5d to 0fa0a1e Compare May 15, 2025 09:49
@supersven supersven force-pushed the WPB-17655-fix-saml-auth-resp-parsing branch from 0fa0a1e to 56c7290 Compare May 15, 2025 13:32
@fisx fisx force-pushed the WPB-17655-fix-saml-auth-resp-parsing branch from 56c7290 to b91b9e0 Compare May 15, 2025 14:25
@fisx fisx force-pushed the WPB-17655-fix-saml-auth-resp-parsing branch from b91b9e0 to 54d9f5f Compare May 15, 2025 15:24
@fisx fisx marked this pull request as ready for review May 15, 2025 20:19
@fisx fisx requested review from a team as code owners May 15, 2025 20:19
Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@supersven supersven merged commit 45ef6ab into develop May 16, 2025
8 checks passed
@supersven supersven deleted the WPB-17655-fix-saml-auth-resp-parsing branch May 16, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants