WPB-16876 allow team admin to add users to a channel they are not in #4574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
battermann
force-pushed
the
WPB-16876-allow-team-admin-to-add-users-and-user-groups-to-a-channel-they-are-not-in
branch
2 times, most recently
from
b5f7407 to
493ee10
Compare
battermann
changed the base branch from
develop
to
WPB-16870-user-groups-create-and-get
zebot
added
the
ok-to-test
battermann
force-pushed
the
WPB-16870-user-groups-create-and-get
branch
from
ff95607 to
446d703
Compare
battermann
force-pushed
the
WPB-16876-allow-team-admin-to-add-users-and-user-groups-to-a-channel-they-are-not-in
branch
from
9f02a25 to
ba9d7f0
Compare
battermann
changed the title
battermann
force-pushed
the
WPB-16876-allow-team-admin-to-add-users-and-user-groups-to-a-channel-they-are-not-in
branch
from
ba9d7f0 to
b6a9003
Compare
battermann
changed the title
battermann
force-pushed
the
WPB-16876-allow-team-admin-to-add-users-and-user-groups-to-a-channel-they-are-not-in
branch
from
b6a9003 to
046ea1a
Compare
supersven
reviewed
Jun 10, 2025
| <> map (,MLSNotificationWelcomeTag) (toList newClients) | ||
|
|
||
| withWebSockets (map fst clients) $ \wss -> do | ||
| r <- k () |
Contributor
There was a problem hiding this comment.
Hm, I'm wondering if it's okay to call the continuation before some other computations. 🤔 (I really don't know.)
Contributor
Author
There was a problem hiding this comment.
It has to be like that, because the continuation in this case is the sending of the commit bundle. This has to be done before notifications can be consumed (the other computations). But thanks for the comment, this lead to a small clean up. :)
supersven
reviewed
Jun 10, 2025
battermann
deleted the
WPB-16876-allow-team-admin-to-add-users-and-user-groups-to-a-channel-they-are-not-in
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-16876
Checklist
changelog.d