More SAML login error details. #4570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
| -- do not use `resp` as a result of `parseAuthnResponseBody`! only use what comes back | ||
| -- from `simpleVerifyAuthnResponse`! | ||
| either (throwError . BadSamlResponseXmlError . cs) pure $ | ||
| either (throwError . BadSamlResponseXmlError . cs . (<> extraErrInfo)) pure $ |
Member
There was a problem hiding this comment.
It could be hard to tell where the error stops and where the response starts. We should perhaps merge the strings with identifier text like parseError: <parseError>, base64Response: <response>
akshaymankar
approved these changes
May 12, 2025
Member
akshaymankar
left a comment
akshaymankar
left a comment
There was a problem hiding this comment.
Assuming its safe to print such details.
This was referenced May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-17585
Checklist
changelog.d