nixpkgs update [WPB-17845] #4569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
supersven
force-pushed
the
sventennie/nixpkgs-update
branch
4 times, most recently
from
4d0184a to
a0931ba
Compare
supersven
force-pushed
the
sventennie/nixpkgs-update
branch
from
0e1ab34 to
39b85e7
Compare
Member
akshaymankar
left a comment
akshaymankar
left a comment
There was a problem hiding this comment.
I think it looks good except for hlint insisting on the functor law. I'd prefer if we ignored that rule.
Comment on lines
297
to
299
| readCredsFromEnv = | ||
| (,) | ||
| <$> (Text.pack <$> getEnv "RABBITMQ_USERNAME") | ||
| ((,) . Text.pack <$> getEnv "RABBITMQ_USERNAME") | ||
| <*> (Text.pack <$> getEnv "RABBITMQ_PASSWORD") |
Member
There was a problem hiding this comment.
I'd have a slight preference to disable this hlint rule because now this looks more confusing.
Contributor
Author
There was a problem hiding this comment.
The hlint Functor law rule is now disabled and the weird changes reverted.
supersven
force-pushed
the
sventennie/nixpkgs-update
branch
from
ab70427 to
1234245
Compare
The old versions don't exist in current nixpkgs.
It was updated in unstable.
Nixpkgs now provies the right version.
Probably, it's only about executing tests...
The mentioned PR has been applied.
Our tasty-ant-xml pin doesn't work with Tasty 1.5.
GHC 9.8 is provided by default by nixpkgs unstable.
It was 2.1.1 before, that's now the default.
The jailbreak is for a newer network package.
fix hlint
We now have to be more precise regarding types (e.g. empty map vs. null.) Also, YAML offset rules seem to be stricter.
`make openapi-validate` works.
The issue has been fixed
The PR has been merged
But the test still fails
The tests even succeed.
supersven
force-pushed
the
sventennie/nixpkgs-update
branch
from
dfb0437 to
73b6522
Compare
The `Functor law` rule leads to odd results.
supersven
force-pushed
the
sventennie/nixpkgs-update
branch
from
73b6522 to
d8ae5f4
Compare
akshaymankar
approved these changes
May 22, 2025
Member
akshaymankar
left a comment
akshaymankar
left a comment
There was a problem hiding this comment.
Looks good, thanks @supersven 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implicit upgrade to GHC 9.8, because that's the new default in
nixpkgs/unstableand some packages require it.Checklist
changelog.d