Fix docker-compose redis replication #4566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We allow only TLS connections to the Redis nodes. Thus we replication has to use TLS as well (by default it doesn't.) See https://redis.io/docs/latest/operate/oss_and_stack/management/security/encryption/#replication
These files are interpreted as "POSIX text files". And, thus should adhere to their standards. See https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206
zebot
added
the
ok-to-test
Contributor
Author
|
|
battermann
approved these changes
May 12, 2025
akshaymankar
approved these changes
May 12, 2025
This was referenced May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've taken some care to put explanations into the commit messages. So, it might make sense to review this PR commit-by-commit.
Ticket: https://wearezeta.atlassian.net/browse/WPB-17247
Checklist
changelog.d