Add a webapp url field to email domain registration (3) #4564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
I had only one usage.
supersven
force-pushed
the
sventennie/WPB-17032_add_webapp_url_to_email_domain_reg_3
branch
from
9009297 to
7b16a36
Compare
3 tasks
fisx
approved these changes
May 12, 2025
| (,) | ||
| <$> fst .= backendUrlSchema | ||
| <$> fst .= field "backend_url" schema | ||
| -- API versions <= V9 ignore the WebApp URL |
Contributor
There was a problem hiding this comment.
is this comment still correct? (was it ever? shouldn't it be <9?)
Contributor
There was a problem hiding this comment.
what is the point of this change?
Contributor
Author
There was a problem hiding this comment.
is this comment still correct? (was it ever? shouldn't it be
<9?)
Thanks for spotting this! 👍 You're right it should be <=V8 or <V9 (which are equal constraints.)
The change itself is just inlining a public function which is only used here. There's no second call site, thus we don't need add this indirection.
supersven
deleted the
sventennie/WPB-17032_add_webapp_url_to_email_domain_reg_3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually, this contains only a small left-over refactoring.
Ticket: https://wearezeta.atlassian.net/browse/WPB-17032
Checklist
Add a new entry in an appropriate subdirectory of(only internal changes)changelog.d