Add a webapp url field to email domain registration (2) #4562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
supersven
force-pushed
the
sventennie/WPB-17032_add_webapp_url_to_email_domain_reg_2
branch
from
5d9484d to
905428d
Compare
supersven
force-pushed
the
sventennie/WPB-17032_add_webapp_url_to_email_domain_reg_2
branch
from
905428d to
6d1d2fc
Compare
supersven
force-pushed
the
sventennie/WPB-17032_add_webapp_url_to_email_domain_reg_2
branch
from
f69069b to
96cd4b9
Compare
pcapriotti
approved these changes
May 5, 2025
Contributor
pcapriotti
left a comment
pcapriotti
left a comment
There was a problem hiding this comment.
Looks good to me, but what's the deal with domainRedirectSchemaV8? Is it even being used anymore?
Contributor
Author
Thanks, @pcapriotti 👍
{
"backend_url": "<url>"
...
}And, {
"backend": {
"config_url": "<url>",
"webapp_url": "<url>"
}
...
} |
supersven
deleted the
sventennie/WPB-17032_add_webapp_url_to_email_domain_reg_2
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PUT /i/domain-registrationandGET /i/domain-registration(both are internal endpoints used only by Stern) are changed in their payloads:backend_urlbecomesconfig_urlin a newbackendfield / object.webapp_urlfield is new.Old payload:
{ "backend_url": "{url}", ... }New payload:
{ "backend": { "config_url": "{url}", "webapp_url": "{url}" }, ... }This change of the payload has also been documented here: https://wearezeta.atlassian.net/wiki/spaces/ENGINEERIN/pages/1570832467/Email+domain+registration+and+configuration#API-changes
Because we don't have system tests for Stern, I also made a quick manual smoke test: Checked that the redirect URL can still be configured and fetched.
Ticket: https://wearezeta.atlassian.net/browse/WPB-17032
Checklist
changelog.d