Add a webapp url field to email domain registration (1) #4559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
supersven
force-pushed
the
sventennie/WPB-17032_add_webapp_url_to_email_domain_reg_1
branch
from
fe37df1 to
829b7f0
Compare
The payload format will change with V9.
... and adjust it in a next step.
Make space for V9 with a new response payload.
We'll work on the same data, only the serialization will differ.
Finally, it's optional and doesn't hurt.
Test 8 (representing the old handler) and the current version (representing the new handler.)
Finally, the webapp url is mandatory in the V9 API.
Add the webapp URL and change the structure according to the spec.
It should be ignored in these endpoints.
This aligns better with names of previous API versions.
supersven
force-pushed
the
sventennie/WPB-17032_add_webapp_url_to_email_domain_reg_1
branch
from
d028923 to
a3ef7ef
Compare
battermann
approved these changes
May 2, 2025
Contributor
battermann
left a comment
battermann
left a comment
There was a problem hiding this comment.
LGTM only minor suggestions
libs/wire-api/src/Wire/API/Routes/Public/Brig/DomainVerification.hs
Outdated
Show resolved
Hide resolved
libs/wire-api/src/Wire/API/Routes/Public/Brig/DomainVerification.hs
Outdated
Show resolved
Hide resolved
…rationResponse schema These should be changed as well. But, in a follow-up PR to keep the scope at a sane size .
supersven
deleted the
sventennie/WPB-17032_add_webapp_url_to_email_domain_reg_1
branch
3 tasks
This was referenced May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm splitting #4542 because it's growing out of bounds.
This PR cares about these endpoints (V9+):
POST /get-domain-registrationPOST /domain-verification/{domain}/backendTicket: https://wearezeta.atlassian.net/browse/WPB-17032
Checklist
changelog.dmake git-add-cassandra-schemato update the cassandra schema documentation