Skip to content

Conversation

@battermann
Copy link
Contributor

@battermann battermann commented Apr 24, 2025

Follow up/ clean up of #4527

The ConversationExisted constructor was never used and therefore removed.

https://wearezeta.atlassian.net/browse/WPB-16875

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Apr 24, 2025
@battermann battermann marked this pull request as ready for review April 24, 2025 08:03
@battermann battermann requested review from a team as code owners April 24, 2025 08:03
Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When did we stop using this?

@battermann
Copy link
Contributor Author

When did we stop using this?

IDK even the previous versions of the handler do not use this, AFAICT. Must have been a long time ago.

Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@battermann battermann merged commit 462bb2c into develop Apr 24, 2025
8 checks passed
@battermann battermann deleted the WPB-16875-team-admin-creates-a-channel-without-joining-follow-up branch April 24, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants