Skip to content

WPB-16953 fix: conversation delete event is cells notification #4551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
battermann merged 3 commits into from
Apr 22, 2025
Merged

WPB-16953 fix: conversation delete event is cells notification #4551

battermann merged 3 commits into from
Apr 22, 2025

Conversation

@battermann
Copy link
Contributor

@battermann battermann commented Apr 22, 2025 •
edited
Loading

https://wearezeta.atlassian.net/browse/WPB-16953

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Apr 22, 2025
@battermann battermann marked this pull request as ready for review April 22, 2025 07:34
@battermann battermann requested review from a team as code owners April 22, 2025 07:34
pcapriotti
pcapriotti approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

changelog.d/3-bug-fixes/WPB-16953 Outdated
@@ -1 +1 @@
Only foward one conversation create event to pydio
Only foward one conversation create event to pydio (#4535, #4551)
Copy link
Contributor

@pcapriotti pcapriotti Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

supersven
supersven approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@battermann battermann merged commit cbb9943 into develop Apr 22, 2025
9 checks passed
@battermann battermann deleted the battermann/fix-conv-delete-not-send branch April 22, 2025 11:57
@zebot zebot mentioned this pull request Apr 25, 2025
Closed
This was referenced May 12, 2025
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcapriotti pcapriotti pcapriotti approved these changes

@supersven supersven supersven approved these changes

Assignees

No one assigned

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@battermann @pcapriotti @supersven @zebot